Skip to content

[TEST] Move test data generation out of logsdb namespace #119994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2025
Merged

[TEST] Move test data generation out of logsdb namespace #119994

merged 2 commits into from
Apr 23, 2025

Conversation

@lkts
Copy link
Contributor

@lkts lkts commented Jan 10, 2025

Just reflecting that it is now used outside of LogsDB testing.

@lkts lkts added >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :StorageEngine/Logs You know, for Logs :StorageEngine/Mapping The storage related side of mappings labels Jan 10, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jan 10, 2025

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@lkts lkts force-pushed the data_generation_move branch 2 times, most recently from f04bfab to 994be6c Compare January 22, 2025 20:32
@lkts lkts removed the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 22, 2025
@lkts lkts mentioned this pull request Jan 22, 2025
Merged
@lkts lkts added auto-backport Automatically create backport pull requests when merged v8.19.0 labels Feb 12, 2025
@lkts lkts force-pushed the data_generation_move branch from 994be6c to 5d16cf6 Compare February 12, 2025 19:22
@lkts lkts force-pushed the data_generation_move branch from e78ad28 to 437ca24 Compare April 22, 2025 16:52
@lkts lkts force-pushed the data_generation_move branch from 437ca24 to 02559e8 Compare April 22, 2025 16:53
martijnvg
martijnvg approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lkts lkts merged commit 5e2b199 into elastic:main Apr 23, 2025
17 checks passed
@lkts lkts deleted the data_generation_move branch April 23, 2025 15:29
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Apr 23, 2025

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 119994

@lkts lkts mentioned this pull request Apr 23, 2025
Merged
@lkts
Copy link
Contributor Author

lkts commented Apr 23, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Questions ?

Please refer to the Backport tool documentation

lkts added a commit that referenced this pull request Apr 23, 2025
@lkts
[TEST] Move test data generation out of logsdb namespace (#119994) (#…
b7aab20 
…127265)

(cherry picked from commit 5e2b199)

# Conflicts:
#	server/src/test/java/org/elasticsearch/index/mapper/blockloader/IpFieldBlockLoaderTests.java
#	server/src/test/java/org/elasticsearch/index/mapper/blockloader/KeywordFieldBlockLoaderTests.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martijnvg martijnvg martijnvg approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged backport pending :StorageEngine/Logs You know, for Logs :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lkts @elasticsearchmachine @martijnvg